Skip to contentSkip to conversation

Change in openvpn[master]: Remove UINT8_MAX definition

Openvpn-devel In review stipa (Code Review) 2 participants 6 messages Apr 15, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1744716809000.I37482a8c322680add00bab52272f9945fbb3bd09@...2715...

#1 lore raw

Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/940?usp=email

to review the following change.

Change subject: Remove UINT8_MAX definition
......................................................................

Remove UINT8_MAX definition

Because this is a part of C99 if uint8_t is available.

Change-Id I37482a8c322680add00bab52272f9945fbb3bd09

---
M src/openvpn/socket.c

1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/40/940/1

src/openvpn/socket.c +0 -4
index bd7a449..a0c22b1 100644
@@ -3036,10 +3036,6 @@
     return BSTR(&buffer);
 }
 
-#ifndef UINT8_MAX
-#define UINT8_MAX 0xff
-#endif
-
 /* add some offset to an ipv6 address
  * (add in steps of 8 bits, taking overflow into next round)
  */

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09
Gerrit-Change-Number: 940
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos, stipa.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/940?usp=email )

Change subject: Remove UINT8_MAX definition
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09
Gerrit-Change-Number: 940
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Attention: stipa <[email protected]...>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:52:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 Remove UINT8_MAX definition

In reply to a message not in the archive

From: Lev Stipakov <[email protected]...>

Because this is a part of C99 if uint8_t is available.

Change-Id I37482a8c322680add00bab52272f9945fbb3bd09

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/940
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

src/openvpn/socket.c +0 -4
index bd7a449..a0c22b1 100644
@@ -3036,10 +3036,6 @@
     return BSTR(&buffer);
 }
 
-#ifndef UINT8_MAX
-#define UINT8_MAX 0xff
-#endif
-
 /* add some offset to an ipv6 address
  * (add in steps of 8 bits, taking overflow into next round)
  */
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: Remove UINT8_MAX definition

Simple enough :-) - buildbots say that all supported platform are fine with this change.

Your patch has been applied to the master branch.

commit ea1e6490a69b6209d6f972a50df8a0d05cb3d27e

Author: Lev Stipakov
Date:   Tue Apr 15 17:52:53 2025 +0200
     Remove UINT8_MAX definition

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg31440.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/940?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: Remove UINT8_MAX definition
......................................................................

Remove UINT8_MAX definition

Because this is a part of C99 if uint8_t is available.

Change-Id I37482a8c322680add00bab52272f9945fbb3bd09

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31440.html

---
M src/openvpn/socket.c

1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/40/940/2

src/openvpn/socket.c +0 -4
index bd7a449..a0c22b1 100644
@@ -3036,10 +3036,6 @@
     return BSTR(&buffer);
 }
 
-#ifndef UINT8_MAX
-#define UINT8_MAX 0xff
-#endif
-
 /* add some offset to an ipv6 address
  * (add in steps of 8 bits, taking overflow into next round)
  */

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09
Gerrit-Change-Number: 940
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/940?usp=email )

Change subject: Remove UINT8_MAX definition
......................................................................

Remove UINT8_MAX definition

Because this is a part of C99 if uint8_t is available.

Change-Id I37482a8c322680add00bab52272f9945fbb3bd09

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31440.html

---
M src/openvpn/socket.c

1 file changed, 0 insertions(+), 4 deletions(-)
src/openvpn/socket.c +0 -4
index bd7a449..a0c22b1 100644
@@ -3036,10 +3036,6 @@
     return BSTR(&buffer);
 }
 
-#ifndef UINT8_MAX
-#define UINT8_MAX 0xff
-#endif
-
 /* add some offset to an ipv6 address
  * (add in steps of 8 bits, taking overflow into next round)
  */

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09
Gerrit-Change-Number: 940
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged